Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example app makeover #519

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Example app makeover #519

merged 2 commits into from
Mar 13, 2024

Conversation

doregg
Copy link
Contributor

@doregg doregg commented Mar 10, 2024 •
edited
Loading

Support hosted/embedded mode in one value change (isomorphic login/logout buttons & effect & provider configuration)
Pages:

  • Home page
  • entitlement page
  • step up with no max age page (button)
  • step up with small max age (button)
  • step up with high max age (button)
  • step up - full page (must be stepped up without a button)
  • Authorized content
  • Private route (legacy)
  • Fallback route

Risk: There is no option to run admin-box tests against this branch, so after this merge, they can fail and block the version branch.
I plan to merge it and check it immediately in the admin box. Worst case - revert

yuvalotem1
yuvalotem1 reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@yuvalotem1 yuvalotem1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can test this change using admin-box pipelines with specific branch name

@doregg doregg merged commit 00883bf into master Mar 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuvalotem1 yuvalotem1 yuvalotem1 approved these changes

@aviadmizrachi aviadmizrachi Awaiting requested review from aviadmizrachi aviadmizrachi is a code owner

@frontegg-david frontegg-david Awaiting requested review from frontegg-david frontegg-david is a code owner

@rotemzif1 rotemzif1 Awaiting requested review from rotemzif1

@amirjaron amirjaron Awaiting requested review from amirjaron amirjaron is a code owner

@MaxArnautFrontegg MaxArnautFrontegg Awaiting requested review from MaxArnautFrontegg MaxArnautFrontegg is a code owner

@TomerFrontegg TomerFrontegg Awaiting requested review from TomerFrontegg TomerFrontegg is a code owner

@mariavlasov mariavlasov Awaiting requested review from mariavlasov mariavlasov is a code owner

@isra-frontegg isra-frontegg Awaiting requested review from isra-frontegg

@AtaliaRefua AtaliaRefua Awaiting requested review from AtaliaRefua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doregg @yuvalotem1