fix(marketing): resolve Astro type warnings and Node indexnow error#809
Open
BlueHotDog wants to merge 1 commit intomainfrom
Open
fix(marketing): resolve Astro type warnings and Node indexnow error#809BlueHotDog wants to merge 1 commit intomainfrom
BlueHotDog wants to merge 1 commit intomainfrom
Conversation
- Extend Window interface in env.d.ts for trackEvent property - Replace deprecated Props import in Head.astro with StarlightRouteData - Add is:inline to JSON-LD script tag in Head.astro - Remove astro.config.mjs import from indexnow.mjs to avoid Node failing on hc-starlight's raw .ts node_modules exports Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windowinterface inenv.d.tsto declaretrackEvent, fixing twots(2568)warnings ingoogleAnalytics.astroPropsimport inHead.astrowithStarlightRouteDatafrom@astrojs/starlight/route-datais:inlinedirective to JSON-LD script tag inHead.astroto silenceastro(4000)hintastro.config.mjsimport fromindexnow.mjs— Node 24 refuses to strip types fromhc-starlight's raw.tsexports innode_modules; the site URL is inlined directly insteadTest Plan
astro checkreports 0 warnings on the 4 previously flagged hintsnode apps/marketing/scripts/indexnow.mjsruns without theERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPINGerror🤖 Generated with Claude Code