Declare missing properties in auth_plugin_anonymous
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 8.2, assigning properties dynamically causes a deprecation warning. To reproduce this specific problem, just set the following in your
config.php
:And go to (for example) http://your.moodle/admin/settings.php?section=authsettinganonymous to see the notice:
This Patch simply adds the missing declarations.
Also, since PHP will coerce values to the declared types of the class properties, the
intval
call becomes unnecessary.Finally, unrelated to the previous issue, but too small for a separate PR:
There was a typo in the same constructor. Instead of
role
the desired config property is calledassignrole
. See line 97 here:auth_anonymous/settings.php
Lines 96 to 103 in 90c5aba
With these changes, using the aforementioned debug configuration will no longer produce warnings/error messages.