Update set of sections, supported by config #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently 'after' always executes on host machine, not in container, while in many cases it might be usefull to execute it inside container. For example in rust to measure test coverage, we should perform 2 steps: 1) cargo llvm-cov --workspace --tests --features full --color never 2) cargo llvm-cov report --html Even if at step 1 some tests fails, we want to execute command 2, to get coverage report even if tests are failed. But exit code should be non-0, based on main command #1. Now best what we can do is to use just "execute": cargo llvm-cov --workspace --tests --features full --color never && cargo llvm-cov report --html This way we will achive main requirement (to get negative exit code if tests will fail), but it will not generate coverage report in case of tests failure. This change would break the logic for existing setups, but furtunately we don't have many at the moment.
Current name is short, but might be a bit misleading and makes user think that certain command can be executed in this particular container only. In the future we plan to add field with explicit list of containers supported per command, but for now lets just make name more clear.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.