Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete_group_mission #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api_schemas/nollning_schema.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,8 @@ class NollningRead(NollningCreate):

class NollningAddGroup(BaseSchema):
group_id: int


class NollningDeleteMission(BaseSchema):
group_id: int
mission_id: int
13 changes: 11 additions & 2 deletions routes/nollning_router.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
from fastapi import APIRouter
from sqlalchemy import desc
from api_schemas.nollning_schema import NollningCreate, NollningRead, NollningAddGroup
from api_schemas.nollning_schema import NollningCreate, NollningRead, NollningAddGroup, NollningDeleteMission
from database import DB_dependency
from db_models.nollning_model import Nollning_DB
from services.nollning_service import add_g_to_nollning, create_nollning, edit_nollning, remove_nollning
from services.nollning_service import add_g_to_nollning, create_nollning, edit_nollning, remove_nollning, delete_group_m
from user.permission import Permission

nollning_router = APIRouter()
Expand Down Expand Up @@ -39,3 +39,12 @@ def delete_nollning(db: DB_dependency, id: int):
)
def add_group_to_nollning(db: DB_dependency, id: int, data: NollningAddGroup):
return add_g_to_nollning(db, id, data)


@nollning_router.delete(
"/delete_group_mission/{id}",
dependencies=[Permission.require("manage", "Nollning")],
response_model=NollningDeleteMission,
)
def delete_group_mission(db: DB_dependency, id: int, data: NollningDeleteMission):
return delete_group_m(db, id, data)
21 changes: 20 additions & 1 deletion services/nollning_service.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
from fastapi import HTTPException
from sqlalchemy.orm import Session
from api_schemas.nollning_schema import NollningAddGroup, NollningCreate
from api_schemas.nollning_schema import NollningAddGroup, NollningCreate, NollningDeleteMission
from db_models.group_model import Group_DB
from db_models.nollning_group_model import NollningGroup_DB
from db_models.nollning_model import Nollning_DB
from db_models.group_mission_model import GroupMission_DB


def create_nollning(db: Session, data: NollningCreate):
Expand Down Expand Up @@ -64,3 +65,21 @@ def add_g_to_nollning(db: Session, id: int, data: NollningAddGroup):
db.refresh(nollning)

return nollning


def delete_group_m(db: Session, id: int, data: NollningDeleteMission):
adventure_mission = (
db.query(GroupMission_DB)
.filter(
GroupMission_DB.nollning_group_id == data.group_id, GroupMission_DB.adventure_mission_id == data.mission_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det borde vara filter_by istället för filter. Annars ser allt rätt ut!

)
.one_or_none()
)

if not adventure_mission:
raise HTTPException(404, detail=f"Adventure mission or group not found")

db.delete(adventure_mission)
db.commit()

return adventure_mission