Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL error customization, coerce input/output fix, variable object coersion, improved Giraffe integration #418

Merged
merged 90 commits into from
Oct 12, 2023
Merged

GraphQL error customization, coerce input/output fix, variable object coersion, improved Giraffe integration #418

merged 90 commits into from
Oct 12, 2023

Conversation

xperiandri
Copy link
Collaborator

  1. Implemented IGQLError and IGQLErrorExtensions to return errors according to the latest GraphQL specification
  2. Added InputParameterValue to distinguish between InlineConstant which comes from GraphQL operation and Variable which comes from variables
  3. Renamed CoerceValue to CoerceOutput
  4. Implemented the whole object construction that comes from variables using coercion of each scalar that it requires
  5. Made Giraffe handler more concise and traceable

@xperiandri
Copy link
Collaborator Author

2 tests are broken:
One because of the need to use Skippable instead of Option
The second is because of the change of the Observable order between home-brew implementation and FSharp.Control.Reactive

@xperiandri
Copy link
Collaborator Author

WebSockets middleware is broken
React samples not tested

This was referenced Jan 12, 2023
Open
Open
@valbers valbers mentioned this pull request Feb 7, 2023
Closed
@xperiandri
Copy link
Collaborator Author

Updated branch

okhorsunenko-lula and others added 18 commits August 9, 2023 17:09
@okhorsunenko-lula
LHK-590 Added modern GraphQL Relay sample project with React (#420)
4286d65 
Co-authored-by: Andrii Chebukin <andrii@lula.is>
Added Type suffix to all built-in GraphQL type definitions
21751b3
WIP Implemented GraphQL error handling using IGQLError instead of `…
38ecfd8 
…Exception` and parsing variables as `JsonElement`
Added @GBirkel as package author
923e82a
Added FieldPath parameter to ParseError function
b0c0488
@GBirkel
Build script now respects "Debug" versus "Release" when when building…
95b5543 
… and launching, when set in the environment with "CONFIGURATION". Default is still Release.
@GBirkel
Starwars server can now find appsettings.json files. Also locates app…
c14c0e9 
… settings.Development.json files. Supposedly this was handled by CreateDefaultBuilder, but it wasn't working. Also respects the "--environment" command line flag for specifying "Developoment".
@GBirkel
Minor logging code typo.
877450b
@GBirkel
Reformatting logging strings and adding additional ones.
2f8a3b5
@GBirkel
Typo and minor formatting.
afe18df
@GBirkel
Fixing up some test descriptions, adding some code commentary.
3815d5a
@GBirkel
Implementing introspection query detection by examining query fields. (…
bfaec8f 
…#7)
Renamed IntrospectionQuery constant to be more readable and fixed que…
8d102c2 
…ry formatting
Updated variable error descriptions
168088a
Fixed scalar default value handling
b7929a5
Fixed error messages about null values for non-nullable types
bf9589b
Added ability to deprecate Field defined win any combination of par…
8dbd7b9 
…ameters
Fixed scalar default value handling
5e6111a
Andrii Chebukin and others added 13 commits September 17, 2023 18:13
valbers
valbers approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@valbers valbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xperiandri xperiandri merged commit 1045ef5 into dev Oct 12, 2023
3 checks passed
@xperiandri xperiandri deleted the IGQLError branch October 12, 2023 21:02
This was referenced Nov 5, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juriyx Juriyx Juriyx approved these changes

@valbers valbers valbers approved these changes

@mickhansen mickhansen Awaiting requested review from mickhansen

@ivelten ivelten Awaiting requested review from ivelten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xperiandri @valbers @Juriyx @okhorsunenko-lula @GBirkel