Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unnecessary parentheses in last tuple item (fsprojects#3082) #3119

Merged
merged 4 commits into from
Sep 14, 2024

Conversation

johnW-ret
Copy link
Contributor

  1. fix for Non needed parentheses are added around lambda call from tuple/members #3082 in CodePrinter.fs
  2. 1 test in TupleTests.fs
  3. Alter test to new intended behavior in OperatorTests.fs

❗CHANGELOG.md change missing (I didn't push it because it was breaking my builds)

@dawedawe
Copy link
Member

Looks good to me :)
Regarding the CHANGELOG.md, does it break your build if you just add this:

## [Unreleased]

### Fixed
* Non needed parentheses are added around lambda call from tuple/members [#3082](https://github.com/fsprojects/fantomas/issues/3082)

Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!
I'm publishing this as a separate revision just in case it leads to invalid code in a scenario we haven't discovered yet.

@nojaf nojaf enabled auto-merge (squash) September 14, 2024 12:15
@nojaf nojaf linked an issue Sep 14, 2024 that may be closed by this pull request
4 tasks
@nojaf nojaf merged commit 06d86ad into fsprojects:main Sep 14, 2024
5 checks passed
@nojaf nojaf mentioned this pull request Sep 17, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non needed parentheses are added around lambda call from tuple/members
3 participants