enhance telegram message

add condition to handle unwanted log messages

.eslintrc.js

@@ -17,6 +17,7 @@ module.exports = {
   ],
   rules: {
     "no-underscore-dangle": 'off',
-    "space-in-parens": 'warn'
+    "space-in-parens": 'warn',
+    "array-bracket-spacing": 'warn'
   },
 };

src/commands/admin/init-exam-channel.ts

@@ -1,33 +1,34 @@
 /* eslint-disable linebreak-style */
+import { GuildChannel, Message } from 'discord.js';
 import { WarningMessageEmbed } from '@/embeds';
 import { getMessage, logger, keyv } from '@/utils';
-import { Message } from 'discord.js';
 
 export default {
   name: 'init-exam-channel',
   guildOnly: true,
   cooldown: 0,
-  permissions: ['ADMINISTRATOR'],
-  execute(message: Message) {
+  permissions: [ 'ADMINISTRATOR' ],
+  execute( message: Message ) {
     const channelId = message.content.split( ' ' )[1];
 
     function isInvalid() {
-      return !(channelId && message.guild?.channels.cache.get(channelId));
+      const examChannel = message.guild?.channels.cache.get( channelId );
+      return !( channelId && examChannel );
     }
 
-    if (isInvalid()) {
+    if ( isInvalid() ) {
       message.reply(
         new WarningMessageEmbed(
           {
-            description: getMessage('command.exams.invalid') + message.content,
+            description: getMessage( 'command.exams.invalid' ) + message.content,
           },
         ),
       );
-      logger.warn(`Invalid Channel ID: "${message.content}" provided`);
+      logger.warn( `Invalid Channel ID: "${message.content}" provided` );
       return;
     }
-    const key = keyv('exams');
-    key.set('channel_id', channelId);
-    logger.info(`New Exam Channel ID: "${channelId}" have been persisted`);
+    const key = keyv( 'exams' );
+    key.set( 'channel_id', channelId );
+    logger.info( `New Exam Channel ID: "${channelId}" have been persisted` );
   },
 };

src/events/exams.ts

@@ -1,7 +1,7 @@
 /* eslint-disable linebreak-style */
+import { Message } from 'discord.js';
 import { SuccessMessageEmbed, WarningMessageEmbed } from '@/embeds';
 import { getMessage, logger, keyv } from '@/utils';
-import { Message } from 'discord.js';
 
 import { sendMessage } from '@/extensions/telegram-bot';
 
@@ -25,7 +25,7 @@ function rejectRequest( rejectedMessage: Message ) {
   );
 }
 
-async function evaluate( message: Message ): Promise< boolean | undefined > {
+async function evaluate( message: Message ): Promise< boolean | undefined | null > {
   const examChannelId = await keyv( 'exams' ).get( 'channel_id' );
 
   if ( !examChannelId ) {
@@ -46,13 +46,17 @@ async function evaluate( message: Message ): Promise< boolean | undefined > {
     replyMessage.delete( deleteOptions );
     return isRequestNotStupid;
   }
-  return undefined;
+  return null;
 }
 
 export default async function examHandler( message: Message ) {
   const result = await evaluate( message );
   if ( typeof result === 'undefined' ) {
-    logger.error( 'Exam evaluation returned an unexpected error' );
+    logger.error( 'Message evaluation for exams returned an unexpected error' );
+    return;
+  }
+  if ( result === null ) {
+    // message was sent in different channel
     return;
   }
   if ( result ) {

src/extensions/telegram-bot.ts

@@ -1,19 +1,36 @@
+/* eslint-disable linebreak-style */
+import { Message } from 'discord.js';
 import environment from '@/environment';
-import { Message } from "discord.js";
 
 const TelegramBot = require( 'node-telegram-bot-api' );
 
 const botConfig = {
-    polling: true
-}
+  polling: true,
+};
 
 const bot = new TelegramBot( environment.telegram_bot_token, botConfig );
 
 async function sendMessage( msg: Message ) {
-    const completeMessage = 'Eine neue Anfrage wurde auf dem Discord Server registriert:\n\n' + msg.cleanContent;
-    bot.sendMessage( environment.telegram_feed_id, completeMessage );
+  // there is no i18n usage here because of only german recipients
+  const formattedDate = msg.createdAt
+    .toLocaleString(
+      'de-DE',
+      // creating a seperate object and assign it as param somehow doesn't work
+      {
+        year: 'numeric',
+        month: '2-digit',
+        day: '2-digit',
+        hour: '2-digit',
+        minute: '2-digit',
+      },
+    );
+  const channelName = msg.guild?.channels.cache.get( msg.channel.id )?.name;
+  const completeMessage = `Eine neue Anfrage wurde auf dem Discord Server im ${channelName}-Channel registriert:\n\n`
+    + `Nickname: ${msg.author.username}\nUser: ${msg.author.tag}\nID: ${msg.author.id}\nZeitstempel: ${formattedDate} Uhr\n\n`
+    + `Nachricht (${msg.id}):\n${msg.cleanContent}`;
+  bot.sendMessage( environment.telegram_feed_id, completeMessage );
 }
 
-export {
-    sendMessage
-}
+export default {
+  sendMessage,
+};