-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure inline_array
keeps attributes
#354
Conversation
We are hitting a hard crash here (on shutdown of the pytest session), which I can only imagine is coming from HDF5 or maybe grib. This will take some debugging... |
Just checking, my guess is this failure is happening on |
Not locally :| |
I just updated the test added here to use a more simple |
Since it's OK for py38 but crashed on py310, suggests a version problem. I note h5py 3.9.0 just came out. |
Confirmed: pinning h5py makes tests pass https://github.com/fsspec/kerchunk/actions/runs/5978456412/job/16220596021?pr=349 |
^ cc @ajelenak |
Pushing the temp fix here, and we can deal with whatever is the underlying problem separately. |
Thanks @martindurant |
Currently
inline_array
won't keep attrs around for arrays that it inlines. This PR makes sure attrs are preserved.cc @martindurant