Handle padding in netcdf3 translation #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make a file with such padding for the sake of tests? |
|
I''ll take a stab. |
|
Added a simple test case to the existing unlimited test. Without the padding being handled as it is in this PR, the test will fail because the temperature offset will be incorrect. If youd prefer it broken out into a separate fixture I can do that too, but wanted to keep it simple |
|
This is perfect |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#365
The padding was not being handled, so the translation crashed because it was not an actual variable. This PR skips the padding but makes sure to increment the offset for each padding chunk encountered.