Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inlining was not happening for HDF #432

Merged
merged 2 commits into from
Mar 5, 2024
Merged

inlining was not happening for HDF #432

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14bf6b3
inlining was not happening for HDF
martindurant Mar 5, 2024
68bd4a0
fixit
martindurant Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions kerchunk/hdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,15 +458,19 @@ def _translator(self, name: str, h5obj: Union[h5py.Dataset, h5py.Group]):
if h5obj.fletcher32:
logging.info("Discarding fletcher32 checksum")
v["size"] -= 4
if self.inline and isinstance(v, list) and v[2] < self.inline:
if (
self.inline
and isinstance(v, dict)
and v["size"] < self.inline
):
self.input_file.seek(v["offset"])
data = self.input_file.read(v["size"])
try:
# easiest way to test if data is ascii
data.decode("ascii")
except UnicodeDecodeError:
data = b"base64:" + base64.b64encode(data)
self.store[k] = data
self.store[za._chunk_key(k)] = data
else:
self.store[za._chunk_key(k)] = [
self._uri,
Expand Down
Loading