add consolidate to single_zarr #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 21, 2024 14:45
kerchunk/zarr.py
Outdated
| inline_threshold=100, | ||
| inline=None, | ||
| out=None, | ||
| translate=False, |
There was a problem hiding this comment.
I think it should just always be True, no need for the kwarg. (Also "translate" is the method on most scanning classes, so would be confusing).
A good argument to optionally include would be an output; at the moment we have out is None (return JSON), or a parquet set; if it were a .json path, we should write to it.
There was a problem hiding this comment.
Apologies pushed an old commit. renamed it to consolidate
There was a problem hiding this comment.
I'll take a look at the write to json
raybellwaves
changed the title
|
I think this is ready for review. I opened #441 to think about writing to json in the function a bit more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.