-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new module and necessary refactorings #500
Conversation
How does this one relate to #499 ? |
@@ -0,0 +1,250 @@ | |||
import ujson |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this module does not have user functions (which should be exposed via kerchunk.grib
), I think the whole module ought to have a docstring to explain this.
kerchunk/grib2.py
Outdated
k_ind.loc[:, "idx"] = idx | ||
return k_ind | ||
|
||
|
||
def build_idx_grib_mapping( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this function not move? I would think it should live in _grib_index
, but it can be imported here, to indicate that, yes, it is user-facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parse_grib_idx and other functions are definitely part of the idx workflow only, I expected they would be moved.
@martindurant I've made the changes as you asked. But the pre-commit is failing on the unused imports when I made the function as user facing in |
You can fix this by including an
|
Should I add the original functions like |
Yes please, add all the public functions, just incase some one does do a "*" import. |
@martindurant made the changes |
This PR adds a new module called
_grib_idx.py
with private functions and added necessary refactorings