Make only one extra bytes vlr per dataset #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
requested review from
n6171028,
MeganDawson42,
mazadbakht,
zqiaofugro and
i-kieu
mazadbakht
reviewed
Jun 12, 2024
MeganDawson42
previously approved these changes
Jun 12, 2024
mazadbakht
reviewed
Jun 12, 2024
mazadbakht
previously approved these changes
Jun 12, 2024
BenCurran98
force-pushed
the
FixHandlingExtraBytes
branch
from
6be101e to
50fc97a
Compare
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
force-pushed
the
FixHandlingExtraBytes
branch
from
50fc97a to
fa5ba6b
Compare
Signed-off-by: BenCurran98 <b.curran@fugro.com>
MeganDawson42
approved these changes
Jun 12, 2024
mazadbakht
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly Treat Extra Bytes VLRs in Dataset
Description
This is to fix an inconsistency with how we treat Extra Bytes VLRs in our datasets. Previously we would allow multiple extra bytes VLRs (one corresponding to each "extra user field") however to be technically correct this should be one VLR that contains the records for all extra bytes inside its payload.
Types of Changes
Tasks
List of tasks you will do to complete the PR
Review