Reverse coordinate system conversion on write #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
requested review from
n6171028,
MeganDawson42,
mazadbakht,
zqiaofugro and
i-kieu
Signed-off-by: BenCurran98 <b.curran@fugro.com>
MeganDawson42
previously approved these changes
Jun 16, 2024
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
MeganDawson42
approved these changes
Jun 16, 2024
i-kieu
approved these changes
Jun 16, 2024
mazadbakht
approved these changes
Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse Coordinate System Conversions When Writing
Description
When reading a LAS dataset, we have the option of converting the positions to metres for convenience for users. However this makes the points inconsistent with header information such as the bounding box and any coordinate system VLRs (OGC WKT format). To fix this, I've avoided messing around with the header stuff when we do the conversion, and instead made it so we keep track of conversion factors applied to points and just reverse this when it's time to write our data. This will mean users can read in a dataset in metres, do their analysis, then write it back in the same format they got it in
Types of Changes
Tasks
List of tasks you will do to complete the PR
LasDatasetReview
List of tasks the reviewer must do to review the PR