add a constructor that just needs the pointcloud #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeganDawson42
force-pushed
the
ConstructorNOHeader
branch
from
beacf57 to
a1654e7
Compare
Signed-off-by: Megan Dawson <meganldawson42@gmail.com>
MeganDawson42
force-pushed
the
ConstructorNOHeader
branch
from
a1654e7 to
6718503
Compare
MeganDawson42
requested review from
n6171028,
mazadbakht,
zqiaofugro and
i-kieu
BenCurran98
previously approved these changes
Jan 6, 2025
Signed-off-by: Megan Dawson <meganldawson42@gmail.com>
i-kieu
reviewed
Jan 6, 2025
src/header.jl
Outdated
| """ | ||
| $(TYPEDSIGNATURES) | ||
|
|
||
| Get the scale for point positions in a LAS file from a header `h`. Checks consistent scale for ALL axis. |
There was a problem hiding this comment.
Axis is singular, if you mean plural it should be axes.
i-kieu
reviewed
Jan 6, 2025
src/header.jl
Outdated
| """ | ||
| function scale(h::LasHeader) | ||
|
|
||
| @assert (h.spatial_info.scale.x == h.spatial_info.scale.y) && (h.spatial_info.scale.y == h.spatial_info.scale.z) "We expect all axis to be scale similarly" |
There was a problem hiding this comment.
Same here and "scaled" for past tense
i-kieu
previously approved these changes
Jan 6, 2025
Signed-off-by: Megan Dawson <meganldawson42@gmail.com>
i-kieu
approved these changes
Jan 7, 2025
zqiaofugro
approved these changes
Jan 7, 2025
BenCurran98
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a LASDataset constructor from a pointcloud (no preconstructed header required)
Description
Minor change to add a constructor from ONLY a pointcloud
Types of Changes
Review
List of tasks the reviewer must do to review the PR