-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexibly Modify Point Contents #49
Draft
BenCurran98
wants to merge
11
commits into
main
Choose a base branch
from
ModifyRecords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
requested review from
n6171028,
MeganDawson42,
mazadbakht,
zqiaofugro and
i-kieu
January 30, 2025 05:28
i-kieu
reviewed
Jan 30, 2025
Comment on lines
+372
to
+373
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra white space.
i-kieu
reviewed
Jan 30, 2025
else | ||
header.legacy_point_return_count = points_per_return | ||
header.legacy_point_return_count = (0, 0, 0, 0, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to return nothing
at the end of this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to flexibly modify point data and header info in LAS Dataset
Description
Adding the functionality to let users modify the point data or header information relating to the point data in a
LASDataset
without invalidating the header of the LAS file.The main use case here is if you have some
LASDataset
and you want to add extra LAS fields to it (that aren't already present, and maybe don't correspond to the point version currently stored in your header). For example, if you have a file with the LasPoint0 format, but want to add an overlap column, you can doThis will update the header information appropriately as well as the actual point data.
Additionally, you can opt to change the point format or las version specifically (without changing the point data itself).
The benefit of these changes is that if you load in a LAS file, do some processing, and then need to output it in a different format, you can do it without having to create a whole new
LASDataset
.On top of this, you can add extra points to your dataset too using the new
add_points!
function (the caveat here is that the points you're adding need to have the exact same fields as those presently in the point cloud).To make this work, I've redone the internals of how we store point data, changing to use a single
FlexTable
instead of a coreTypedTable
and an optionalFlexTable
just containing user data. This may be slightly less performant in some operations over the point data due to type inference overhead, however I think the flexibility in the UI justifies thisTypes of Changes
Tasks
LASDataset
objectsadd_column!
to work for LAS fields as well as user fieldsLASDataset
Review