add validate function before deploy.

deploy.go

@@ -83,7 +83,7 @@ func (app *App) Deploy(opt DeployOption) error {
 	}
 
 	log.Printf("[info] starting deploy function %s", *fn.FunctionName)
-	if _, err := app.lambda.GetFunction(&lambda.GetFunctionInput{
+	if current, err := app.lambda.GetFunction(&lambda.GetFunctionInput{
 		FunctionName: fn.FunctionName,
 	}); err != nil {
 		if aerr, ok := err.(awserr.Error); ok {
@@ -93,6 +93,8 @@ func (app *App) Deploy(opt DeployOption) error {
 			}
 		}
 		return err
+	} else if err := validateUpdateFunction(current.Configuration, current.Code, fn); err != nil {
+		return err
 	}
 
 	if err := app.prepareFunctionCodeForDeploy(opt, fn); err != nil {

diff.go

@@ -47,6 +47,10 @@ func (app *App) Diff(opt DiffOption) error {
 		fmt.Println(color.GreenString("+++" + *opt.FunctionFilePath))
 		fmt.Println(coloredDiff(ds))
 	}
+
+	if err := validateUpdateFunction(latest, code, newFunc); err != nil {
+		return err
+	}
 	return nil
 }
 

lambroll.go

@@ -278,3 +278,27 @@ func exportEnvFile(file string) error {
 	}
 	return nil
 }
+
+var errCannotUpdateImageAndZip = errors.New("cannot update function code between Image and Zip")
+
+func validateUpdateFunction(currentConf *lambda.FunctionConfiguration, currentCode *lambda.FunctionCodeLocation, newFn *lambda.CreateFunctionInput) error {
+	newCode := newFn.Code
+
+	// new=Image
+	if newCode != nil && newCode.ImageUri != nil || aws.StringValue(newFn.PackageType) == packageTypeImage {
+		// current=Zip
+		if currentCode == nil || currentCode.ImageUri == nil {
+			return errCannotUpdateImageAndZip
+		}
+	}
+
+	// current=Image
+	if currentCode != nil && currentCode.ImageUri != nil || aws.StringValue(currentConf.PackageType) == packageTypeImage {
+		// new=Zip
+		if newCode == nil || newCode.ImageUri == nil {
+			return errCannotUpdateImageAndZip
+		}
+	}
+
+	return nil
+}