Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct color configuration in CLI #436

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

soh335
Copy link
Contributor

@soh335 soh335 commented Sep 25, 2024

  • Fixed the logic for color.NoColor by inverting the opts.Color flag to ensure color output behaves as expected.
  • Note: This change will result in logs being output without color by default, whereas previously they were colored by default.

- Fixed the logic for `color.NoColor` by inverting the `opts.Color` flag to ensure color output behaves as expected.
- Changed the default value for the `Color` option to `true`, as the behavior would change when the color flag is not specified. This ensures colored output by default unless explicitly disabled.
@fujiwara
Copy link
Owner

fujiwara commented Oct 2, 2024

@soh335 Thank you!

Note: This change will result in logs being output without color by default, whereas previously they were colored by default.

Now --color is true by default, So colored logs are enabled by default, too.
But the previous v1.1.0 had the same behavior (=v1.1.0 is broken).

@fujiwara fujiwara merged commit 94aabe2 into fujiwara:v1 Oct 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants