Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: require that the poetry lock file is up to date #64

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

nh13
Copy link
Member

@nh13 nh13 commented Oct 18, 2023

No description provided.

@nh13 nh13 force-pushed the nh_MS_rtd_theme branch 4 times, most recently from dc6386b to 27402c2 Compare October 18, 2023 18:37
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (MS_rtd_theme@04ed0d7). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff               @@
##             MS_rtd_theme      #64   +/-   ##
===============================================
  Coverage                ?   92.90%           
===============================================
  Files                   ?       30           
  Lines                   ?     3016           
  Branches                ?      559           
===============================================
  Hits                    ?     2802           
  Misses                  ?      143           
  Partials                ?       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 requested a review from msto October 18, 2023 23:35
@nh13
Copy link
Member Author

nh13 commented Oct 18, 2023

@msto so basically I had to:

  1. update the version of poetry we require to 1.5
  2. add poetry lock --check to our github action
  3. add the sphinx_rtd_theme dependency to the pyproject.yaml. I think you had added it manually as part of the docs, but didn't add it to the main dependency. Take a look. The typical way to add a new dependency is with poetry add.
  4. cherry-pick ed6df15 from refactor: use pathlib in tests #65

Copy link
Contributor

@msto msto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@nh13 nh13 merged commit d31d5e4 into MS_rtd_theme Oct 19, 2023
@nh13 nh13 deleted the nh_MS_rtd_theme branch October 19, 2023 15:56
msto added a commit that referenced this pull request Oct 19, 2023
* doc: use rtd theme

* ci: require that the poetry lock file is up to date (#64)

* ci: require that the poetry lock file is up to date
* refactor: use pathlib in tests
* chore: lock via poetry
* chore: update poetry version to 1.5
* fix: add sphinx_rtd_theme and update lock

---------

Co-authored-by: Matt Stone <matt@fulcrumgenomics.com>

---------

Co-authored-by: Nils Homer <nh13@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants