Replaced default constructors with static methods

fulminazzo · Apr 13, 2024 · e7a399f · e7a399f
1 parent 86367ba
commit e7a399f
Showing 1 changed file with 50 additions and 30 deletions.
diff --git a/item/bukkit/src/main/java/it/angrybear/yagl/items/PersistentItem.java b/item/bukkit/src/main/java/it/angrybear/yagl/items/PersistentItem.java
@@ -36,48 +36,23 @@ public class PersistentItem extends BukkitItemImpl {
     private @Nullable InteractItemAction interactAction;
     private Mobility mobility;
 
-    /**
-     * Instantiates a new Persistent item.
-     */
-    public PersistentItem() {
+    private PersistentItem() {
         this((String) null);
     }
 
-    /**
-     * Instantiates a new Persistent item.
-     *
-     * @param material the material
-     */
-    public PersistentItem(final @NotNull Material material) {
+    private PersistentItem(final @NotNull Material material) {
         this(material.name(), 1);
     }
 
-    /**
-     * Instantiates a new Persistent item.
-     *
-     * @param material the material
-     */
-    public PersistentItem(final @Nullable String material) {
+    private PersistentItem(final @Nullable String material) {
         this(material, 1);
     }
 
-    /**
-     * Instantiates a new Persistent item.
-     *
-     * @param material the material
-     * @param amount   the amount
-     */
-    public PersistentItem(final @NotNull Material material, final int amount) {
+    private PersistentItem(final @NotNull Material material, final int amount) {
         this(material.name(), amount);
     }
 
-    /**
-     * Instantiates a new Persistent item.
-     *
-     * @param material the material
-     * @param amount   the amount
-     */
-    public PersistentItem(final @Nullable String material, final int amount) {
+    private PersistentItem(final @Nullable String material, final int amount) {
         super(material, amount);
         this.deathAction = DeathAction.MAINTAIN;
         this.mobility = Mobility.STATIC;
@@ -301,6 +276,51 @@ public PersistentItem copy() {
         return null;
     }
 
+    /**
+     * Instantiates a new Persistent item.
+     */
+    public static PersistentItem newItem() {
+        return new PersistentItem();
+    }
+
+    /**
+     * Instantiates a new Persistent item.
+     *
+     * @param material the material
+     */
+    public static PersistentItem newItem(final @NotNull Material material) {
+        return new PersistentItem(material);
+    }
+
+    /**
+     * Instantiates a new Persistent item.
+     *
+     * @param material the material
+     */
+    public static PersistentItem newItem(final @Nullable String material) {
+        return new PersistentItem(material);
+    }
+
+    /**
+     * Instantiates a new Persistent item.
+     *
+     * @param material the material
+     * @param amount   the amount
+     */
+    public static PersistentItem newItem(final @NotNull Material material, final int amount) {
+        return new PersistentItem(material, amount);
+    }
+
+    /**
+     * Instantiates a new Persistent item.
+     *
+     * @param material the material
+     * @param amount   the amount
+     */
+    public static PersistentItem newItem(final @Nullable String material, final int amount) {
+        return new PersistentItem(material, amount);
+    }
+
     /**
      * Clear persistent items.
      */