fix: fix bug in scip freeConstraints and gurobi setConstraints crash#44
Merged
tlambert03 merged 5 commits intofunkelab:mainfrom Nov 10, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
===========================================
- Coverage 91.90% 65.93% -25.97%
===========================================
Files 4 17 +13
Lines 383 822 +439
Branches 0 155 +155
===========================================
+ Hits 352 542 +190
- Misses 31 219 +188
- Partials 0 61 +61
|
tlambert03
changed the title
funkey
requested changes
Nov 9, 2023
Member
funkey
left a comment
funkey
left a comment
There was a problem hiding this comment.
Thanks a lot! I think there is a potential memory leak in ScipBackend, otherwise looks good to me.
funkey
approved these changes
Nov 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the SCIP freeConstraints no-op bug...
but there is still a crash in the gurobi backend (that should appear in the tests now)... and bug in gurobi clear is also fixed