Skip to content

ci: add c++ coverage#45

Merged
tlambert03 merged 5 commits intofunkelab:mainfrom
tlambert03:gcov
Nov 9, 2023
Merged

ci: add c++ coverage#45
tlambert03 merged 5 commits intofunkelab:mainfrom
tlambert03:gcov

Conversation

@tlambert03
Copy link
Copy Markdown
Member

trying to add gcov coverage of the c++ code to the codecov reports here

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 9, 2023

Codecov Report

Merging #45 (4fc1056) into main (d1fb38d) will decrease coverage by 26.18%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #45       +/-   ##
===========================================
- Coverage   91.90%   65.72%   -26.18%     
===========================================
  Files           4       17       +13     
  Lines         383      817      +434     
  Branches        0      151      +151     
===========================================
+ Hits          352      537      +185     
- Misses         31      221      +190     
- Partials        0       59       +59     

see 14 files with indirect coverage changes

@tlambert03
Copy link
Copy Markdown
Member Author

nice! it works!

@tlambert03
Copy link
Copy Markdown
Member Author

tlambert03 commented Nov 9, 2023

coverage takes a big hit here... but it's more honest :)

unfortunately, the gurobi license doesn't seem to be working anymore, so we're not getting any gurobi backend coverage. will try to fix in a followup

edit: scratch that, they do work, but not on PRs from forks. So, the coverage works on main

@tlambert03 tlambert03 merged commit 3385d84 into funkelab:main Nov 9, 2023
@tlambert03 tlambert03 deleted the gcov branch November 9, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant