Skip to content

refactor: optimize coefficient extraction to avoid recursion limits#81

Merged
tlambert03 merged 1 commit intofunkelab:mainfrom
tlambert03:fix-recursion2
Oct 17, 2025
Merged

refactor: optimize coefficient extraction to avoid recursion limits#81
tlambert03 merged 1 commit intofunkelab:mainfrom
tlambert03:fix-recursion2

Conversation

@tlambert03
Copy link
Copy Markdown
Member

another attempt to fix #64

this uses an explicit stack rather than recursion

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (0fdfae7) to head (de15fe8).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   75.72%   83.45%   +7.73%     
==========================================
  Files          17       11       -6     
  Lines         828      810      -18     
  Branches      154        0     -154     
==========================================
+ Hits          627      676      +49     
+ Misses        136      134       -2     
+ Partials       65        0      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03 tlambert03 merged commit c0196ad into funkelab:main Oct 17, 2025
17 checks passed
@tlambert03 tlambert03 deleted the fix-recursion2 branch October 17, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Infinite recursion when adding MaxParents(1) constraint

1 participant