Added Accordion2D to the UI sub module
#487
Conversation
|
Hello @antrikshmisri! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-24 18:42:15 UTC |
Garyfallidis
changed the title
Accorion2D to the UI sub moduleAccordion2D to the UI sub module
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
===========================================
+ Coverage 50.46% 88.87% +38.41%
===========================================
Files 120 31 -89
Lines 28024 7129 -20895
Branches 2987 853 -2134
===========================================
- Hits 14142 6336 -7806
+ Misses 13413 563 -12850
+ Partials 469 230 -239
|
There was a problem hiding this comment.
Hi @antrikshmisri,
Can you rebase this PR and address my small comments. After that, I will have a deeper look and come back to you.
Thank you.
| # -*- coding: utf-8 -*- | ||
| """ | ||
| ================================================ | ||
| Example to demonstrate the use of Accordion2D UI |
There was a problem hiding this comment.
What is the difference from the previous one? You need to add more information to the description.
|
Also, there is some pep8 issues, it would be great if you could address them. thank you |
* master: (1622 commits) Test scipy import fix finalize remove scene from window in snapshot tests: leak on test_record fix: iren shouldn't be created inside of record method fix: double render call with timeline obj causes a seg fault updated glTF tutorials Let them loop Updated glTF animation tests Renamed some timelines leftovers Migrated glTF anim to the new animation sys Altered current_timestamp of single animations update sphinx team version lowercase updating videos with lower res removing extra comma skip marker_actor on linux skip test_timer fix some vtkerror update requirements ...
+ Add more description to the Accordion2D examples + Add window.record to the Accordion2D examples
+ Add imports that were removed in the previous merge conflict resolution.
|
ok, thank you for the feedback @antrikshmisri, I will look at #460 first |
This PR adds the
.
Accordion2DUI to theUIsub module. Please merge #460 before reviewing/merging this. Below is a screenshot for reference:-