-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Up to Date ColorPicker UI Element #651
Draft
saran820
wants to merge
11
commits into
fury-gl:master
Choose a base branch
from
saran820:colorpicker
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
21804c8
Added Colorpicker to elements.py
saran820 ff7eaa3
Removed colorpicker from elements.py and Added to core.py
saran820 0e9ed4b
Added ColorPicker to __all__
saran820 8ac3b94
Changed _add_to_renderer to _add_to_scene
saran820 d7be308
Resolved Indentation Error
saran820 7b71cf9
Resolved Indentation Error
saran820 397eb11
Resolved Indentation Error
saran820 5dd26e9
Removed colorpicker from core.py to elements.py
saran820 2a68d25
Removed position parameter from super..
saran820 7dc25e0
Updated old functions to newer updated versions - ColorPicker
saran820 3f2e698
Merge branch 'fury-gl-master' into colorpicker
saran820 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @saran820 ,
I am not sure if you are still working on it or not but I figured out why the interaction wasn't working for
Rectangle2D
.If you change these lines of code as suggested, the below code would work.
Modified Code: