Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Adding getters and setters for the TextBlock2D properties #830

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

ganimtron-10
Copy link
Contributor

Recent PR #803 added many properties to the TextBlock2D for improving its functionality.
This is a continuing PR which adds getter and setters for those.
Primarily focusing on auto_font_size & dynamic_bbox.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #830 (b053c88) into master (2551b7f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #830      +/-   ##
==========================================
+ Coverage   84.30%   84.32%   +0.02%     
==========================================
  Files          44       44              
  Lines       10353    10370      +17     
  Branches     1406     1407       +1     
==========================================
+ Hits         8728     8745      +17     
  Misses       1255     1255              
  Partials      370      370              
Files Changed Coverage Δ
fury/ui/core.py 93.43% <100.00%> (+0.21%) ⬆️

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !, thanks @ganimtron-10, merging

@skoudoro skoudoro merged commit 9a9cf7f into fury-gl:master Aug 7, 2023
20 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants