Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC: Adding Week 12 Blogpost #843

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Conversation

ganimtron-10
Copy link
Contributor

image

@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #843 (8b7e0ea) into master (e0741be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #843   +/-   ##
=======================================
  Coverage   84.49%   84.49%           
=======================================
  Files          44       44           
  Lines       10454    10454           
  Branches     1411     1411           
=======================================
  Hits         8833     8833           
  Misses       1252     1252           
  Partials      369      369           

Copy link
Contributor

@JoaoDell JoaoDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ganimtron-10, just reviewed your blogpost, which built fine, and everything seems ok. Thanks for describing your progress related to #832, I got a better understanding of what is goind on now 👍

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ganimtron-10, the blogpost is clear and well-explained, now I understand better what PR #832 is about. I just left one comment for you to check.

docs/source/posts/2023/2023-08-19-week-12-praneeth.rst Outdated Show resolved Hide resolved
@ganimtron-10
Copy link
Contributor Author

Thanks @JoaoDell @tvcastillod for the review!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, Thanks @ganimtron-10, merging

@skoudoro skoudoro merged commit 0d9d229 into fury-gl:master Aug 29, 2023
19 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants