Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the bug in line 118 #858

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed the bug in line 118 #858

wants to merge 2 commits into from

Conversation

DanonymousCoder
Copy link

Changed z4= z2 * z2

@skoudoro
Copy link
Contributor

Hi @DanonymousCoder,

Thank you for this. Can you provide the reference of this and add a unit test ? thank you

@DanonymousCoder
Copy link
Author

Ok @skoudoro

@skoudoro
Copy link
Contributor

Finally, I looked deeper, and no need to add a reference.

you just need to update the test:

fury/fury/tests/test_colormap.py

Line 12 in 7804f58

def test_boys2rgb():

@skoudoro skoudoro added the type:Bug Fix Something isn't working label Jan 26, 2024
@DanonymousCoder
Copy link
Author

DanonymousCoder commented Jan 28, 2024 •
edited
Loading

Is this okay ? @skoudoro

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:Bug Fix Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanonymousCoder @skoudoro