-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: GSoC Robin Final Report #929
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving. As i don't see any technical issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @robinroy03 ,
overall looks good. Just make more explicit where is your work/repo for all elements.
it is a. bit hidden. otherwise, see the comments below
@WassCodeur is working hard to remove all documentation warnings so please, fix those warnings (it is almost done): |
@m-agour, @itellaetxe and @WassCodeur, please review. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that you've done a great job, and I've learned a lot from you, thanks for sharing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, Robin. Again, this sounds like wizardy to me and I think it is a super cool project using cutting-edge tech. You found a very clever way to use LLMs. I wish I could do something like this!
On the other hand, I read through it carefully and it looks very neat and concise. The explanations are well structured, and the figures help understand what you are trying to say. I really like the figure that explains the architecture.
Again, super inspiring project. Keep it up.
As for the review, I +1'd some comments from the other reviewers, so you do not miss them. Other than those, I could not find anything that would need to be changed. LGTM, Approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robinroy03, Please look at my suggestions below. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @robinroy03! merging
Final report. The remaining blog posts will be linked when the PRs are merged.
Preview