Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Fix documentation warnings #932

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

jhlegarreta
Copy link
Contributor

@jhlegarreta jhlegarreta commented Aug 27, 2024

  • DOC: Fix hyperlink syntax in blog entry
  • DOC: Use simple hyperlink syntax to link an internal file
  • DOC: Fix misplaced column separation character in table
  • DOC: Remove a spare whitespace in a table cell

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented Aug 27, 2024

OK, so 44ce158 is working:

So the above commits uncover some new warnings. I am transferring 44ce158 to another PR so that this can be merged. Other contributors can have a look at the uncovered warnings.

Edit: PR #933.

Fix hyperlink syntax in blog entry: add a missing whitespace between the
displayed text and the target URL.

Fixes:
```
/fury/docs/source/posts/2023/2023-01-29-final-report-shivam.rst::
 ERROR: Anonymous hyperlink mismatch: 1 references but 0 targets.
See "backrefs" attribute for IDs.
```

raised for example at:
https://github.com/fury-gl/fury/actions/runs/10530916380/job/29181869908#step:7:551
Use simple hyperlink syntax to link an intenal file instead of using
both the `:doc:` directive and hyperlink syntax.

Fixes:
```
/fury/fury/docs/source/posts/2023/2023-07-17-week-7-tvcastillod.rst:19:
 WARNING: Mismatch: both interpreted text role prefix and reference suffix.
```

raised for example at:
https://github.com/fury-gl/fury/actions/runs/10530916380/job/29181869908#step:7:553
@jhlegarreta jhlegarreta force-pushed the FixDocWarnings branch 2 times, most recently from b012b16 to 2c19312 Compare August 27, 2024 23:04
Copy link
Member

@WassCodeur WassCodeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta LGTM!

It would be preferable to squash the commits into a single commit

Fix misplaced column separation character in table: move the column
separation `+` character so that it is aligned with the rest of the
column separation characters in a blog entry table.
Remove a spare whitespace in a table cell.i
@jhlegarreta
Copy link
Contributor Author

OK, doc build is clean and there are no warnings. PR #933 can be merged right after.

@WassCodeur Each commit serves a well-defined purpose, so it is better to leave them separately.

@WassCodeur
Copy link
Member

OK, doc build is clean and there are no warnings. PR #933 can be merged right after.

@WassCodeur Each commit serves a well-defined purpose, so it is better to leave them separately.

Algriht. We'll be waiting for @skoudoro now.

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jhlegarreta and thanks for the review @WassCodeur .

LGTM, merging

@skoudoro skoudoro merged commit 49ec5c0 into fury-gl:master Aug 28, 2024
17 of 29 checks passed
@jhlegarreta jhlegarreta deleted the FixDocWarnings branch August 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants