Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relay Management / Outbox Model #41

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Relay Management / Outbox Model #41

merged 6 commits into from
Nov 12, 2024

Conversation

prolic
Copy link
Collaborator

@prolic prolic commented Oct 25, 2024 •
edited
Loading

Relay Management / Outbox Model

Core Changes

  1. Complete rewrite of relay connection handling

    • Separated DM relays from general relays
    • Added proper connection state management
    • Improved error handling and retry logic
    • Added connection status tracking and UI feedback

  2. New Relay Management UI

    • Added dedicated relay management dialog
    • Visual connection status indicators
    • Separate handling for DM vs general relays
    • Add/remove relay functionality
    • Connection state monitoring

  3. Architecture Changes

    • Split relay handling into separate modules
    • Added RelayConnection module for connection management
    • Added Publisher module for event broadcasting
    • Improved state management with separate RelayPoolState

  4. Protocol Implementation

    • Added support for NIP-65 (Outbox Model)
      • Smart event publishing to appropriate relays
      • Publisher module handles write-only relays
      • Efficient event distribution
    • Added support for NIP-17 (Preferred DM Relays)
      • Dedicated DM relay management
      • Automatic DM relay list publishing
      • DM relay discovery and synchronization

Key Features

  • Real-time relay connection status display
  • Connection retry handling with visual feedback
  • Separate inbox/outbox relay configuration
  • Improved DM relay management
  • Better error handling and user feedback
  • Persistent relay configurations
  • Smart event publishing via outbox model
  • Efficient DM relay handling

Technical Improvements

  • More robust websocket connection handling
  • Better state management for connections
  • Improved error recovery
  • Better type safety around relay configurations
  • Protocol-compliant event publishing

@prolic prolic marked this pull request as draft October 25, 2024 01:11
@prolic prolic changed the title [WIP] Relay mgmt [WIP] Relay Management Oct 26, 2024
@prolic prolic changed the title [WIP] Relay Management [WIP] Relay Management / Outbox Model Oct 29, 2024
prolic
prolic commented Oct 30, 2024
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
@prolic prolic self-assigned this Oct 30, 2024
@prolic prolic added the enhancement New feature or request label Oct 30, 2024
@alltheseas alltheseas mentioned this pull request Oct 30, 2024
Open
prolic
prolic commented Nov 11, 2024
View reviewed changes
cabal.project Outdated Show resolved Hide resolved
@prolic
fix chat window glitch
1fd7d76
@prolic
- Add support for Outbox Model (NIP-65)
d2ad43e 
- Add support for preferred DM relays (NIP-17)
- Add Relay Management UI
- Add Publish Manager tracking publish status
- Add granular UI updates to reduce unnecessary refreshes
@prolic
cleanup RelayConnection and Util
c30b5b4
@prolic
QML reads in new treads UI changes and does max 10 updates per second
b7dbfd2
@prolic
fix connection establishment
84d0389
@prolic
- Remove redundant thread management in nostrClient
b02b3b8 
- Use async/waitAnyCancel pattern for read/write loops
- Clean up connection termination logic
- Remove unnecessary reconnection logic from nostrClient
- Add proper error handling in send/receive loops
@prolic prolic changed the title [WIP] Relay Management / Outbox Model Relay Management / Outbox Model Nov 12, 2024
@prolic prolic linked an issue Nov 12, 2024 that may be closed by this pull request
NIP-17: Kind 10050 indicates the user's preferred relays to receive DMs. #39
Closed
@prolic prolic marked this pull request as ready for review November 12, 2024 22:09
@prolic prolic merged commit 810d2ae into master Nov 12, 2024
2 checks passed
@prolic prolic deleted the relay_mgmt branch November 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@prolic prolic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NIP-17: Kind 10050 indicates the user's preferred relays to receive DMs.
1 participant
@prolic