Modal navigation stack presentation detents #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarek41
previously approved these changes
Jan 28, 2025
added 6 commits
January 28, 2025 19:19
This reverts commit ad0d927. # Conflicts: # Sources/FuturedArchitecture/Architecture/NavigationStackFlow.swift
ssestak
force-pushed
the
feature/Modal-navigation-stack-presentation-detents
branch
from
535b2a9 to
f2025f1
Compare
jmarek41
approved these changes
Feb 5, 2025
ssestak
deleted the
feature/Modal-navigation-stack-presentation-detents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of Presentation detents for NavigationStack.
In next PR I will add support for "height" detent, since it's more complex and not so clean in code base. Than we can decide if we want to support "heigh" detent as well.
In iOS 18+, presentation detents start working for this case even if you defined detent in Component of rootView of NavigationStack. In pervious versions iOS this not works 😞.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-28.at.12.42.25.mp4