Skip to content

Commit

Permalink
Merge branch 'release/0.2.2'
Browse files Browse the repository at this point in the history
  • Loading branch information
HenrikBengtsson committed Jul 3, 2024
2 parents 0f68255 + b5e6075 commit 77a3ad8
Show file tree
Hide file tree
Showing 10 changed files with 36 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/covr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
## https://app.codecov.io/gh/<org>/<repo>/settings
## 2. Set 'CODECOV_TOKEN' in GitHub Secrets:
## https://github.com/<org>/<repo>/settings/environments/
coverage <- covr::package_coverage()
coverage <- covr::package_coverage(quiet = FALSE)
print(coverage)
covr::codecov(coverage = coverage, token="${{secrets.CODECOV_TOKEN}}")
shell: Rscript {0}
10 changes: 5 additions & 5 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Package: future.mirai
Version: 0.2.1
Version: 0.2.2
Depends:
future
Imports:
mirai (>= 0.12.1),
mirai (>= 1.1.0),
parallelly,
utils
Suggests:
Expand All @@ -25,7 +25,7 @@ Authors@R: c(
))
License: GPL (>= 3)
Encoding: UTF-8
URL: https://future.mirai.futureverse.org, https://github.com/HenrikBengtsson/future.mirai
BugReports: https://github.com/HenrikBengtsson/future.mirai/issues
RoxygenNote: 7.3.1
URL: https://future.mirai.futureverse.org, https://github.com/futureverse/future.mirai
BugReports: https://github.com/futureverse/future.mirai/issues
RoxygenNote: 7.3.2
Roxygen: list(markdown = TRUE)
10 changes: 9 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# Version (development version)
# Version 0.2.2

## Miscellaneous

* Internal updates for **mirai** (>= 1.1.0), e.g. `mirai::daemons()`
argument `resilience` is being removed.


# Version 0.2.1

## Bug Fix

Expand Down
2 changes: 1 addition & 1 deletion R/MiraiFuture-class.R
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ MiraiFuture <- function(expr = NULL,
daemons(n = 0L)
} else if (workers != nworkers) {
daemons(n = 0L) ## reset is required
daemons(n = workers, dispatcher = dispatcher, resilience = FALSE)
daemons(n = workers, dispatcher = dispatcher)
}
} else if (!is.null(workers)) {
stop("Argument 'workers' should be a numeric scalar or NULL: ", mode(workers))
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div id="badges"><!-- pkgdown markup -->
<a href="https://CRAN.R-project.org/web/checks/check_results_future.mirai.html"><img b
order="0" src="https://www.r-pkg.org/badges/version/future.mirai" alt="CRAN check status"/></a> <a href="https://github.com/HenrikBengtsson/future.mirai/actions?query=workflow%3AR-CMD-check"><img border="0" src="https://github.com/HenrikBengtsson/future.mirai/actions/workflows/R-CMD-check.yaml/badge.svg?branch=develop" alt="R CMD check status"/></a> <a href="https://github.com/HenrikBengtsson/future.mirai/actions?query=workflow%3Afuture_tests"><img border="0" src="https://github.com/HenrikBengtsson/future.mirai/actions/workflows/future_tests.yaml/badge.svg?branch=develop" alt="future.tests checks status"/></a> <a href="https://app.codecov.io/gh/HenrikBengtsson/future.mirai"><img border="0" src="https://codecov.io/gh/HenrikBengtsson/future.mirai/branch/develop/graph/badge.svg" alt="Coverage Status"/></a>
order="0" src="https://www.r-pkg.org/badges/version/future.mirai" alt="CRAN check status"/></a> <a href="https://github.com/futureverse/future.mirai/actions?query=workflow%3AR-CMD-check"><img border="0" src="https://github.com/futureverse/future.mirai/actions/workflows/R-CMD-check.yaml/badge.svg?branch=develop" alt="R CMD check status"/></a> <a href="https://github.com/futureverse/future.mirai/actions?query=workflow%3Afuture_tests"><img border="0" src="https://github.com/futureverse/future.mirai/actions/workflows/future_tests.yaml/badge.svg?branch=develop" alt="future.tests checks status"/></a> <a href="https://app.codecov.io/gh/futureverse/future.mirai"><img border="0" src="https://codecov.io/gh/futureverse/future.mirai/branch/develop/graph/badge.svg" alt="Coverage Status"/></a>
</div>

# future.mirai: A Future API for Parallel Processing using 'mirai'
Expand Down Expand Up @@ -112,15 +112,15 @@ To install the pre-release version that is available in Git branch
`develop` on GitHub, use:

```r
remotes::install_github("HenrikBengtsson/future.mirai", ref="develop")
remotes::install_github("futureverse/future.mirai", ref="develop")
```

This will install the package from source.


[mirai]: https://cran.r-project.org/package=mirai
[future]: https://cran.r-project.org/package=future
[future.mirai]: https://github.com/HenrikBengtsson/future.mirai
[future.mirai]: https://cran.r-project.org/package=future.mirai
[future.apply]: https://cran.r-project.org/package=future.apply
[furrr]: https://cran.r-project.org/package=furrr
[doFuture]: https://cran.r-project.org/package=doFuture
Expand Down
11 changes: 4 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
# CRAN submission future.mirai 0.2.1
# CRAN submission future.mirai 0.2.2

on 2024-05-14
on 2024-07-03

This submission attempts to fix a check error that occurs sporadically
and has been reported on the CRAN check servers.

Thanks in advance
<no comments>


## Notes not sent to CRAN
Expand All @@ -19,7 +16,7 @@ The package has been verified using `R CMD check --as-cran` on:
| 3.6.x | L | |
| 4.2.x | L W | |
| 4.3.x | L M W | W |
| 4.4.x | | M1 W |
| 4.4.x | | . W |
| devel | L M W | W |

*Legend: OS: L = Linux, M = macOS, M1 = macOS M1, W = Windows*
4 changes: 2 additions & 2 deletions man/future.mirai.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkgdown/_pkgdown.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ url: https://future.mirai.futureverse.org
home:
links:
- text: Roadmap/Milestones
href: https://github.com/HenrikBengtsson/future.mirai/milestones
href: https://github.com/futureverse/future.mirai/milestones
- text: The Futureverse Project
href: https://www.futureverse.org/
- text: Futureverse User Forum
Expand Down
2 changes: 1 addition & 1 deletion pkgdown/_pkgdown.yml.rsp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ url: https://<%= pkg %>.futureverse.org
home:
links:
- text: Roadmap/Milestones
href: https://github.com/HenrikBengtsson/<%= pkg %>/milestones
href: https://github.com/<%= gsub("(^.*:|[.]git$)", "", subset(gert::git_remote_list(), name == "origin")$url) %>/milestones
- text: The Futureverse Project
href: https://www.futureverse.org/
- text: Futureverse User Forum
Expand Down
9 changes: 9 additions & 0 deletions tests/mirai_cluster,worker-termination.R
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,17 @@ if (.Platform$OS.type != "windows") {
## cf. https://github.com/HenrikBengtsson/future.mirai/issues/7
nworkers <- tryCatch(nbrOfWorkers(), error = identity)
print(nworkers)

## If a valid result, then validate the value
if (!inherits(nworkers, "error")) {
message("Number of workers: ", nworkers)
message("Expected number of workers: ", all - 1L)
count <- 0L
while (nworkers != all - 1L && count < 5L) {
Sys.sleep(1.0)
nworkers <- tryCatch(nbrOfWorkers(), error = identity)
message("Number of workers: ", nworkers)
}
stopifnot(nworkers == all - 1L)
}

Expand Down

0 comments on commit 77a3ad8

Please sign in to comment.