Lint code and add tests.

fyc09 · Jul 18, 2024 · 8a30e08 · 8a30e08
1 parent c5b9c27
commit 8a30e08
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 86 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -412,7 +412,7 @@ module.exports.getLineMetadata = getLineMetadata;
  * @param {boolean} inTable Iff in a table.
  * @param {boolean} inItem Iff in a list item.
  * @param {boolean} inBreak Iff in semantic break.
- * @param {boolean} inHTML Iff in HTML.
+ * @param {boolean} inHtml Iff in HTML block.
  * @returns {void}
  */
 
@@ -4216,8 +4216,9 @@ module.exports = {
   "tags": [ "headings", "atx", "spaces" ],
   "parser": "none",
   "function": function MD018(params, onError) {
-    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHTML) => {
-      if (!inCode && !inHTML &&
+    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHtml) => {
+      if (!inCode &&
+        !inHtml &&
         /^#+[^# \t]/.test(line) &&
         !/#\s*$/.test(line) &&
         !line.startsWith("#️⃣")) {
@@ -4359,8 +4360,9 @@ module.exports = {
   "tags": [ "headings", "atx_closed", "spaces" ],
   "parser": "none",
   "function": function MD020(params, onError) {
-    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHTML) => {
-      if (!inCode && !inHTML) {
+    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHtml) => {
+      if (!inCode &&
+        !inHtml) {
         const match =
           /^(#+)([ \t]*)([^#]*?[^#\\])([ \t]*)((?:\\#)?)(#+)(\s*)$/.exec(line);
         if (match) {

diff --git a/helpers/helpers.js b/helpers/helpers.js
@@ -400,7 +400,7 @@ module.exports.getLineMetadata = getLineMetadata;
  * @param {boolean} inTable Iff in a table.
  * @param {boolean} inItem Iff in a list item.
  * @param {boolean} inBreak Iff in semantic break.
- * @param {boolean} inHTML Iff in HTML.
+ * @param {boolean} inHtml Iff in HTML block.
  * @returns {void}
  */
 

diff --git a/lib/md018.js b/lib/md018.js
@@ -13,8 +13,9 @@ module.exports = {
   "tags": [ "headings", "atx", "spaces" ],
   "parser": "none",
   "function": function MD018(params, onError) {
-    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHTML) => {
-      if (!inCode && !inHTML &&
+    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHtml) => {
+      if (!inCode &&
+        !inHtml &&
         /^#+[^# \t]/.test(line) &&
         !/#\s*$/.test(line) &&
         !line.startsWith("#️⃣")) {

diff --git a/lib/md020.js b/lib/md020.js
@@ -13,8 +13,9 @@ module.exports = {
   "tags": [ "headings", "atx_closed", "spaces" ],
   "parser": "none",
   "function": function MD020(params, onError) {
-    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHTML) => {
-      if (!inCode && !inHTML) {
+    forEachLine(lineMetadata(), (line, lineIndex, inCode, inFence, inTable, inItem, inBreak, inHtml) => {
+      if (!inCode &&
+        !inHtml) {
         const match =
           /^(#+)([ \t]*)([^#]*?[^#\\])([ \t]*)((?:\\#)?)(#+)(\s*)$/.exec(line);
         if (match) {

diff --git a/test/ignore-html-block.md b/test/ignore-html-block.md
@@ -1,15 +1,13 @@
 # ignore-html-block.md
 
-## Title
+<style> {MD033}
 
-##Title2 {MD018}
+##Heading 1
 
-<div> {MD033}
-#foo
-</div>
+##  Heading 2
 
-##Title3 {MD020}##
+##Heading 3##
 
-<div> {MD033}
-#foo#
-</div>
+##  Heading 4  ##
+
+</style>
diff --git a/test/snapshots/markdownlint-test-scenarios.js.md b/test/snapshots/markdownlint-test-scenarios.js.md
@@ -17219,70 +17219,15 @@ Generated by [AVA](https://avajs.dev).
 
     {
       errors: [
-        {
-          errorContext: '##Title2 {MD018}',
-          errorDetail: null,
-          errorRange: [
-            1,
-            3,
-          ],
-          fixInfo: {
-            editColumn: 3,
-            insertText: ' ',
-          },
-          lineNumber: 5,
-          ruleDescription: 'No space after hash on atx style heading',
-          ruleInformation: 'https://github.com/DavidAnson/markdownlint/blob/v0.0.0/doc/md018.md',
-          ruleNames: [
-            'MD018',
-            'no-missing-space-atx',
-          ],
-        },
-        {
-          errorContext: '##Title3 {MD020}##',
-          errorDetail: null,
-          errorRange: [
-            1,
-            3,
-          ],
-          fixInfo: {
-            deleteCount: 18,
-            editColumn: 1,
-            insertText: '## Title3 {MD020} ##',
-          },
-          lineNumber: 11,
-          ruleDescription: 'No space inside hashes on closed atx style heading',
-          ruleInformation: 'https://github.com/DavidAnson/markdownlint/blob/v0.0.0/doc/md020.md',
-          ruleNames: [
-            'MD020',
-            'no-missing-space-closed-atx',
-          ],
-        },
         {
           errorContext: null,
-          errorDetail: 'Element: div',
+          errorDetail: 'Element: style',
           errorRange: [
             1,
-            5,
-          ],
-          fixInfo: null,
-          lineNumber: 7,
-          ruleDescription: 'Inline HTML',
-          ruleInformation: 'https://github.com/DavidAnson/markdownlint/blob/v0.0.0/doc/md033.md',
-          ruleNames: [
-            'MD033',
-            'no-inline-html',
-          ],
-        },
-        {
-          errorContext: null,
-          errorDetail: 'Element: div',
-          errorRange: [
-            1,
-            5,
+            7,
           ],
           fixInfo: null,
-          lineNumber: 13,
+          lineNumber: 3,
           ruleDescription: 'Inline HTML',
           ruleInformation: 'https://github.com/DavidAnson/markdownlint/blob/v0.0.0/doc/md033.md',
           ruleNames: [
@@ -17293,19 +17238,17 @@ Generated by [AVA](https://avajs.dev).
       ],
       fixed: `# ignore-html-block.md␊
       ␊
-      ## Title␊
+      <style> {MD033}␊
       ␊
-      ## Title2 {MD018}␊
+      ##Heading 1␊
       ␊
-      <div> {MD033}␊
-      #foo␊
-      </div>␊
+      ##  Heading 2␊
       ␊
-      ## Title3 {MD020} ##␊
+      ##Heading 3##␊
       ␊
-      <div> {MD033}␊
-      #foo#␊
-      </div>␊
+      ##  Heading 4  ##␊
+      ␊
+      </style>␊
       `,
     }
 

diff --git a/test/snapshots/markdownlint-test-scenarios.js.snap b/test/snapshots/markdownlint-test-scenarios.js.snap