bug fix: use filter instead of get query (#250)

fylein · Aug 8, 2023 · a1c8283 · a1c8283
1 parent 6c75afc
commit a1c8283
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/apps/workspaces/views.py b/apps/workspaces/views.py
@@ -436,16 +436,9 @@ def get(self, request, *args, **kwargs):
         users = workspace.user.all()
         for user in users:
             admin = User.objects.get(user_id=user)
-            name = ExpenseAttribute.objects.get(
-                value=admin.email, 
-                workspace_id=kwargs['workspace_id'],
-                attribute_type='EMPLOYEE'
-            ).detail['full_name']
-
-            admin_email.append({
-                'name': name,
-                'email': admin.email
-            })
+            employee = ExpenseAttribute.objects.filter(value=admin.email, workspace_id=kwargs['workspace_id'], attribute_type='EMPLOYEE').first()
+            if employee:
+                admin_email.append({'name': employee.detail['full_name'], 'email': admin.email})
 
         return Response(
                 data=admin_email,