moving views logic to actions #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
+ Coverage 97.23% 97.27% +0.03%
==========================================
Files 50 54 +4
Lines 3259 3299 +40
==========================================
+ Hits 3169 3209 +40
Misses 90 90
☔ View full report in Codecov by Sentry. |
ashwin1111
approved these changes
Aug 24, 2023
Ashutosh619-sudo
added
the
deploy
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
Ashutosh619-sudo
temporarily deployed
to
Staging
GitHub Actions
Inactive
ruuushhh
approved these changes
Aug 25, 2023
apps/workspaces/actions.py
Outdated
| def connect_xero(authorization_code, redirect_uri, workspace_id): | ||
|
|
||
| if redirect_uri: | ||
| refresh_token = generate_xero_refresh_token(authorization_code, redirect_uri) |
ruuushhh
reviewed
Aug 25, 2023
| xero_exc.InvalidTokenError, xero_exc.UnsuccessfulAuthentication, | ||
| xero_exc.WrongParamsError, xero_exc.NoPrivilegeError, | ||
| xero_exc.InternalServerError): | ||
| pass |
There was a problem hiding this comment.
Please check this indentation as well
Ashutosh619-sudo
temporarily deployed
to
CI Environment
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.