Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated files and update .gitignore #394

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

madmini
Copy link
Contributor

@madmini madmini commented Jun 20, 2024

added some relevant .gitignore entries from https://github.com/flutter/flutter/blob/master/.gitignore

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 20, 2024

Good job! However, I am not sure whether that is the best way. For example, in flutter/flutter#13892 there seems to be many possible gitignores. Could you please check whether those entries are all suggested to be there or not?

@madmini
Copy link
Contributor Author

madmini commented Jun 20, 2024

As the discussion in the linked issue seems to indicate, there is no canonical .gitignore. I believe the one from the main flutter repo may be the closest thing to a complete .gitignore.

As for the entries I copied from there, flutter/flutter#13554 (and the corresponding merged PR) says that these are not intended to be checked in.
In addition, each of these files has a header that says Generated file, do not edit. and is regenerated when running or building the apps.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 20, 2024

Looks reasonable and thanks for the contribution!

@fzyzcjy fzyzcjy merged commit ff4150c into fzyzcjy:master Jun 20, 2024
10 checks passed
@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 20, 2024

@all-contributors please add @madmini for code

Copy link
Contributor

@fzyzcjy

@madmini already contributed before to code

@madmini madmini deleted the chore/remove-generated-files branch June 28, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants