Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reportSavePath argument #398

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

madmini
Copy link
Contributor

@madmini madmini commented Jun 27, 2024

Allow saving reports to a specified location instead of a temporary dir.

A weird thing is that build_runner renamed _$_ITIMState to _$ITIMState which required a change in non-generated files.

The config options are all over the place, despite what the readme says. Maybe global_config_store.dart should be extracted to common and include all options (and a bit of documentation for what exactly they do).

@madmini
Copy link
Contributor Author

madmini commented Jun 27, 2024

Also, for me it would be way more intuitive if the managers saved the reports to /path/to/project/convenient_test_reports or similar by default. I did not think to check temp dir until i looked at the code.

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 28, 2024

Good job!

A weird thing is that build_runner renamed

Just a guess: maybe because the dependency version changes and feature changes

@fzyzcjy
Copy link
Owner

fzyzcjy commented Jun 28, 2024

Also, for me it would be way more intuitive if the managers saved the reports to /path/to/project/convenient_test_reports or similar by default. I did not think to check temp dir until i looked at the code.

That looks reasonable! However, this will be a breaking change if we do so today... So maybe we can change defaults later in v2 in the future.

@fzyzcjy fzyzcjy merged commit a29c586 into fzyzcjy:master Jun 28, 2024
11 checks passed
@madmini madmini deleted the feature/add-report-save-path-arg branch June 28, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants