Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omarluq/dependency updates #45

Closed
wants to merge 2 commits into from
Closed

Omarluq/dependency updates #45

wants to merge 2 commits into from

Conversation

omarluq
Copy link
Member

@omarluq omarluq commented Dec 1, 2023

No description provided.

@omarluq omarluq force-pushed the omarluq/dependency-updates branch from 551e903 to 850c5ef Compare December 1, 2023 01:37
dknox20
dknox20 reviewed Dec 1, 2023
View reviewed changes
Copy link

@dknox20 dknox20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on making the version bump separate from the dependency changes?

@omarluq
Copy link
Member Author

omarluq commented Dec 1, 2023

Thoughts on making the version bump separate from the dependency changes?

@dknox20 yes that makes way more sense, would you like it in 2 PR's or just 2 commits?

@omarluq
Copy link
Member Author

omarluq commented Dec 1, 2023

@dknox20 should I add another PR that addresses Rubocop violation "metadata['rubygems_mfa_required'] must be set to 'true'".

@dknox20
Copy link

dknox20 commented Dec 1, 2023

Thoughts on making the version bump separate from the dependency changes?

@dknox20 yes that makes way more sense, would you like it in 2 PR's or just 2 commits?

Hmm, Ok guess multiple PRs. Not sure that is right but I do think the version bump should be separate in normal circumstances.

@dknox20
Copy link

dknox20 commented Dec 1, 2023

@dknox20 should I add another PR that addresses Rubocop violation "metadata['rubygems_mfa_required'] must be set to 'true'".

Would add this into the PR that is updating Rails dependencies. I know it is unrelated sorta but is necessary for our evolutionary change philosophy.

@omarluq omarluq force-pushed the omarluq/dependency-updates branch 2 times, most recently from 862db9b to 9d0b3ec Compare December 2, 2023 00:00
@omarluq omarluq requested a review from dknox20 December 6, 2023 21:20
@omarluq omarluq force-pushed the omarluq/dependency-updates branch from 9d0b3ec to dd1e289 Compare December 6, 2023 21:23
@omarluq omarluq force-pushed the omarluq/dependency-updates branch 2 times, most recently from 8ba5ba5 to 8fb9969 Compare December 11, 2023 15:22
@omarluq omarluq force-pushed the omarluq/dependency-updates branch from 8fb9969 to ba7cf77 Compare January 9, 2024 18:14
@dknox20
Copy link

dknox20 commented Sep 25, 2024

@omarluq should we close or update this PR?

@omarluq
Copy link
Member Author

omarluq commented Oct 1, 2024

@omarluq should we close or update this PR?

I will close it and rework these PR's for rails 7.2 support

@omarluq omarluq closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dknox20 dknox20 Awaiting requested review from dknox20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarluq @dknox20