Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install vue-color and vue-cookie as ESM packages #302

Merged
merged 4 commits into from
Jan 18, 2023
Merged

Install vue-color and vue-cookie as ESM packages #302

merged 4 commits into from
Jan 18, 2023

Conversation

Raruto
Copy link
Collaborator

@Raruto Raruto commented Jan 13, 2023 •
edited by volterra79
Loading

Start addressing: #290

List of changes

  • delete folder src/assets/vendors/vue-color/
  • delete folder src/assets/vendors/vue/cookie/
  • update gulp task concatenate:vendor_js accordingly
  • update tests config test/config/vendors.js accordingly
  • installed npm dependencies accordingly (ref: package.json)
  • add file src/deprecated.js in order to ensure backward compatibilities (ref: window.VueColor and window.VueCookie)
  • where possible to update references to the above variables with static imports (ESM modules)

For more info:

TODO:

  • manual tests for components that make use of VueColor plugin
  • manual tests for components that make use of VueCookie plugin
  • run automated tests (ie. npm run test)

@Raruto
install vue-color and vue-cookie as ESM packages
f1d89ca 
- delete folder `src/assets/vendors/vue-color/`
- delete folder `src/assets/vendors/vue/cookie/`
- update gulp task `concatenate:vendor_js`
- update tests config `test/config/vendors.js`
- add file `src/deprecated.js` in order to ensure backward compatibilities (ref: `window.VueColor` and `window.VueCookie`)
@Raruto Raruto added the dependencies Pull requests that update a dependency file label Jan 13, 2023
@Raruto Raruto added this to the v3.8 milestone Jan 13, 2023
@Raruto Raruto marked this pull request as ready for review January 18, 2023 08:57
@volterra79 volterra79 merged commit ec53d68 into dev Jan 18, 2023
@volterra79 volterra79 deleted the import-vue-plugins branch January 18, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volterra79 volterra79 volterra79 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
v3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Raruto @volterra79