-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new npm / glup tasks: clone:default_plugins
, build:dev_plugins
, watch:plugins
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the aforementioned task in order to make sure that core client plugins are there before starting develop: - [submodule "src/plugins/qplotly"] <-- https://github.com/g3w-suite/g3w-client-plugin-qplotly.git - [submodule "src/plugins/qtimeseries"] <-- https://github.com/g3w-suite/g3w-client-plugin-qtimeseries.git - [submodule "src/plugins/editing"] <-- https://github.com/g3w-suite/g3w-client-plugin-editing.git
Raruto
commented
Jan 18, 2023
Raruto
commented
Jan 19, 2023
Raruto
changed the title
Add new gulp task
Add new npm / glup tasks: Jan 31, 2023
clone:default_plugins
gulp clone:default_plugins
, gulp build:dev_plugins, npm run watch:plugins
Raruto
changed the title
Add new npm / glup tasks:
Add new npm / glup tasks: Jan 31, 2023
gulp clone:default_plugins
, gulp build:dev_plugins, npm run watch:plugins
gulp clone:default_plugins
, gulp build:dev_plugins
, npm run watch:plugins
Raruto
changed the title
Add new npm / glup tasks:
Add new npm / glup tasks: Jan 31, 2023
gulp clone:default_plugins
, gulp build:dev_plugins
, npm run watch:plugins
clone:default_plugins
, build:dev_plugins
, watch:plugins
Raruto
commented
Feb 3, 2023
@volterra79 are we ready to merge this?, otherwise we will never test it enough before the next release.. |
volterra79
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Raruto let's do it
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #301 and #262
What's changes:
Add new task
gulp clone:default_plugins
,in order to make sure that core client plugins are there before starting develop:
Add new task
gulp build:dev_plugins
,in order to maker sure that core and custom client bundles are up-to-date before starting the
npm run dev
server(NB: for performance reasons this script just
build
all plugins once, for watching them all see next point)Add new script
npm run watch:plugins
,in order to avoid performing the
gulp watch
task on each plugin located in the localsrc/plugins/*
directoryUpdate
README.md
plugin development instructionsRemove useful gulp tasks
definitely deprecated (and undocumented), the following tasks crash if run manually because their dependent tasks were never implemented:
gulp.task('g3w-admin-client:static', ['build:static']);
gulp.task('g3w-admin-client:template', ['build:templates']);
gulp.task('g3w-admin:static', ['build:static']);
gulp.task('g3w-admin:templates', ['build:templates']);
Advantages of this type of solution
Drawbacks
The following files are not yet generated automatically (to do this you still need to manually run thebuild:plugins
task):The version of the cloned repositories is not fixed to a specific release (ie. to a specific branch or commit), so an unsuspecting user could clone a version of the client plugins not immediately compatible with the current version of g3w-client
each developer has to worry about keeping various plugin repositories up-to-date locally