Add src/components/MapControlGeocoding.js and src/components/MapControlNominatimResults.js
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volterra79
added a commit
that referenced
this pull request
Mar 30, 2023
* Add ZoomHistory Map Control * Create ZoomHistoryMapControl.vue component * clean up some code * rename file: `components/ZoomHistoryMapControl.vue` --> `components/MapControlZoomHistory.vue` Use same prefix as: - #329 - #330 * fix computed method: `hasEmptyHistory()` * Add i18n translation as QGIS Desktop tools * update translations * Fix issue on watch history.index. Remove watch property and move to methods last and next because when move map (zoom or pan) index is updated and map back to previous extent * Set new icon * Move zoomhistory according #388 (comment) * 👀 jsdoc tags must be setted above each term... ..otherwise you could break your IDE intellisense * remove duplicated function call: `_addControlToMapControlsLeftBottom` * comments --------- Co-authored-by: Raruto <Raruto@users.noreply.github.com>
# Conflicts: # src/app/g3w-ol/controls/geocodingcontrol.js # src/components/index.js
volterra79
approved these changes
Aug 8, 2023
Raruto
commented
Aug 8, 2023
volterra79
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
src/app/g3w-ol/controls/geocodingcontrol.jsandsrc/components/MapControlGeocoding.jssrc/components/MapControlNominatimResults.jsRelated to #193 and preparatory for #85