Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing object type fix #82

Merged
merged 16 commits into from
Jul 16, 2024
Merged

missing object type fix #82

merged 16 commits into from
Jul 16, 2024

Conversation

mbaudis
Copy link
Member

@mbaudis mbaudis commented May 24, 2023

ResultsetInstance was missing the "type" parameter which leads to errors when creating instances.

Tis is an urgent fix w/o any changes to the schema etc. and IMO should directly go into main instead of develop etc.

mbaudis and others added 5 commits December 22, 2022 12:37
The validation directories are confusing & not part of the framework itself.
…esponse

Removing mentions to "aggregated" granularity in the code.
…mnants

removing the validation directories
`ResultsetInstance` was missing the "type" parameter which leads to errors when creating instances.
@mbaudis mbaudis requested review from jrambla and costero-e May 24, 2023 09:27
@costero-e
Copy link
Collaborator

Yes, this can be considered a hotfix so I agree this is one of the case scenarios in which a PR directly to main is appropriate.

@jrambla
Copy link
Contributor

jrambla commented May 26, 2023

I miss an update to Change.MD in order to notify the change.
However, I'm a little confused that it is not working as it is now (w/o the "type" attribute), as we have tested throught schema validators.
Just tested again with a mock schema and document. Removing "type: object" doesn't raises any complaint from the validator.

@mbaudis
Copy link
Member Author

mbaudis commented May 26, 2023

@jrambla The missing object type can lead to schema parsers failing to transverse the schema structure. In my testing failed to instantiate an object from the schema. But anyway - should be there as everywhere else.

mbaudis and others added 3 commits May 26, 2023 10:31
This is a pure documentation change for the handover format. Addresses #83
@costero-e
Copy link
Collaborator

we need @jrambla approval here to close this PR

@jrambla
Copy link
Contributor

jrambla commented Jan 9, 2024

This PR requires a review from the current status

@costero-e
Copy link
Collaborator

These are fixes that won't break the specification, just addressing examples for ageOfOnset, which were including the entry definitions (and the schema don't need to add this information), as well as adding object type for ResultSetInstance (and other format fixes). Still 1 pending review.

@costero-e costero-e merged commit de014e8 into main Jul 16, 2024
1 check passed
@costero-e costero-e modified the milestones: 2.1, 2.0.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants