-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entryTypeDefinition description #92
Conversation
The parameter descriptions in the EntryTypeDefinitions schema seem somewhat hard to parse and potentially misleading - this is a go at cleaning them up a bit.
It is not clear how to use ontologyTermForThisType w/o examples (i.e. terms for biosample, individual... - added some but incomplete...) and there is also a logical duplication having a "unique" id and an ontology term. Overall this should be clarified but the current modification seems (a) sensible (step).
It is not clear how to use ontologyTermForThisType w/o examples (i.e. terms for biosample, individual... - added some but incomplete...) and there is also a logical duplication having a "unique" id and an ontology term. Overall this should be clarified but the current modification seems (a) sensible (step). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the changes you made, as it makes it more clear to know what is an entry Type. Thank you. I approved the changes but I have a particular opinion (that maybe is wrong) for the entry Type description: Definition of an element or entry type, to describe each type of entry type included in a beacon
I think it would be better to not use "entry Type" in its own definition, maybe we could use "scope" here, as I see it as, correct me if I'm wrong, a similar term for entry Type. For example we could have something like: Definition of an element or scope of the element, to describe each type of entry type included in a beacon
The rest I see it correct and you are right we should extend the list of ontologyTermForThisType.
Excellent! |
Updated the definition with a new commit! |
The purpose of ontologyTermForThisType is to allow a semantic description of the model. |
The parameter descriptions in the EntryTypeDefinitions schema seem somewhat hard to parse and potentially misleading - this is a go at cleaning them up a bit.