-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/live score update #20
Conversation
I remember what I meant... it was from when I only planned to allow 2 players in a game at once. Other players could specate the two players live
gameSession.turnCount++; | ||
|
||
handleNewScore(gameSession, userId, score).catch(console.error); | ||
player.score = score; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
user controlled input
gameSession.players[userId].score = score; | ||
if (!body.partial) { | ||
handleNewScore(gameSession, userId, score).catch(console.error); | ||
player.done = true; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
user controlled input
switch (gameSession.game) { | ||
case Game.WORD_HUNT: | ||
gameSession.players[userId].words = body.words; | ||
player.words = body.words; |
Check warning
Code scanning / CodeQL
Prototype-polluting assignment Medium
user controlled input
Those warnings are so true. But CBA to replace everything with maps right now. |
closes gabeklavans/word-hunt-online#6