Add update subpath #107
Open
Add update subpath #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udnay
force-pushed
the
add-update-lens
branch
4 times, most recently
from
e2e79fa to
833371b
Compare
udnay
force-pushed
the
add-update-lens
branch
from
833371b to
da48712
Compare
udnay
force-pushed
the
add-update-lens
branch
from
2f10bb4 to
9ad8784
Compare
udnay
force-pushed
the
add-update-lens
branch
from
29a2f4e to
2ee54aa
Compare
airhorns
reviewed
Feb 24, 2025
| subpathsPredicate := "" | ||
| if len(qb.objectQuery.Subpaths) > 0 { | ||
| subpathsPredicate = "AND o.path LIKE ALL(__subpaths__::text[])" | ||
| } |
There was a problem hiding this comment.
I guess this option isn't mutually exclusive with ignores right -- you could use both at once? And we'll just let PG decide which conditions to use the index for?
There was a problem hiding this comment.
You can use both at once, ignoring a subset of the files under the subpaths. I initially wanted to use it like (haskell's lens)[https://github.com/ekmett/lens/wiki/Overview] functionality where the subpaths focus you on a specific set of the project and let you manipulate just that. With that in mind I thought keeping the ignores made sense.
airhorns
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a
subpathto object queries. This is similar to kuberentes' subpath construct for volume mounts where a subpath can be used to specify a particular directory within the volume to mount. The same idea applies here where a set subpath prefixes can be used to narrow down the query to rebuild or update just the objects in the selected subpath and not the whole project.