fix: render sprite incorrectly caused by diff algorithm when config r…

…eusable
galacean · Dec 17, 2023 · fe87365 · fe87365
1 parent 86e0bce
commit fe87365
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 16 deletions.
diff --git a/packages/effects-core/src/plugins/sprite/sprite-mesh.ts b/packages/effects-core/src/plugins/sprite/sprite-mesh.ts
@@ -194,24 +194,20 @@ export class SpriteMesh {
     const uSizeStart = start + 4;
     const uQuatStart = start + 8;
     const uColorStart = start + 12;
-
-    if (!selfData.visible && !init) {
-      mainDataArray[uSizeStart + 2] = -1;
-
-      return;
-    }
-
-    const uColor = selfData.color || [mainDataArray[uColorStart], mainDataArray[uColorStart + 1], mainDataArray[uColorStart + 2], mainDataArray[uColorStart + 3]];
-
-    // if (selfData.startSize) {
-    //   selfData.transform.scaleBy(1 / selfData.startSize[0], 1 / selfData.startSize[1], 1);
-    // }
-
     const tempPos = new Vector3();
     const tempQuat = new Quaternion();
     const tempScale = new Vector3();
+    const uColor = selfData.color || [mainDataArray[uColorStart], mainDataArray[uColorStart + 1], mainDataArray[uColorStart + 2], mainDataArray[uColorStart + 3]];
 
-    selfData.transform.assignWorldTRS(tempPos, tempQuat, tempScale);
+    if (selfData.visible) {
+      selfData.transform.assignWorldTRS(tempPos, tempQuat, tempScale);
+    } else {
+      if (!init) {
+        mainDataArray[uSizeStart + 2] = -1;
+
+        return;
+      }
+    }
 
     const uPos = [...tempPos.toArray(), 0];
     const uSize = [...tempScale.toArray(), 0];

diff --git a/web-packages/demo/src/single.ts b/web-packages/demo/src/single.ts
@@ -3,14 +3,13 @@ import '@galacean/effects-plugin-spine';
 import '@galacean/effects-plugin-model';
 import inspireList from './assets/inspire-list';
 
-const json = inspireList.preComp.url;
+const json = 'https://mdn.alipayobjects.com/mars/afts/file/A*3mT3SJ4KGKYAAAAAAAAAAAAADlB4AQ';
 const container = document.getElementById('J-container');
 
 (async () => {
   try {
     const player = createPlayer();
 
-    const comp = await player.loadScene(json);
   } catch (e) {
     console.error('biz', e);
   }