Merge origin/main into origin/feat/2.0 #317
Conversation
fix: 修复预合成缩放设置不生效的问题
Merge origin/main into origin/dev
fix: 预合成元素初始化时未创建的问题
fix: 修复多次引用同一个预合成元素的渲染顺序问题
Merge origin/dev into origin/main
docs: changelog 1.3.2
WalkthroughVersion 1.3.2 of the Changes
Poem
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (15)
Files skipped from review due to trivial changes (10)
Additional Context UsedLanguageTool (87)
GitHub Check Runs (1)
Additional comments not posted (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -13,7 +13,7 @@ | |||
| container, | |||
| }); | |||
|
|
|||
| await player.loadScene(json, { | |||
| await player.loadScene('https://mdn.alipayobjects.com/mars/afts/file/A*s4IgQru1WyEAAAAAAAAAAAAADlB4AQ', { | |||
There was a problem hiding this comment.
Consider using a constant for the URL to improve maintainability and ensure proper escaping in contexts like regular expressions.
- await player.loadScene('https://mdn.alipayobjects.com/mars/afts/file/A*s4IgQru1WyEAAAAAAAAAAAAADlB4AQ', {
+ const SCENE_URL = 'https://mdn.alipayobjects.com/mars/afts/file/A\\*s4IgQru1WyEAAAAAAAAAAAAADlB4AQ';
+ await player.loadScene(SCENE_URL, {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| await player.loadScene('https://mdn.alipayobjects.com/mars/afts/file/A*s4IgQru1WyEAAAAAAAAAAAAADlB4AQ', { | |
| const SCENE_URL = 'https://mdn.alipayobjects.com/mars/afts/file/A\\*s4IgQru1WyEAAAAAAAAAAAAADlB4AQ'; | |
| await player.loadScene(SCENE_URL, { |
| // renderFramework: 'webgl', | ||
| // env: 'editor', |
There was a problem hiding this comment.
Consider removing commented-out code if it's not intended for future use, to keep the codebase clean.
- // renderFramework: 'webgl',
- // env: 'editor',
- // reportGPUTime: console.debug,Also applies to: 45-45
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| // renderFramework: 'webgl', | |
| // env: 'editor', |
Summary by CodeRabbit
New Features
effects-runtime.Bug Fixes
effects-runtime.Documentation
Tests