Fix import_monthly_binance_prices in processing.py

galacticcouncil · Jun 27, 2023 · c283616 · c283616
1 parent 6e1d0bc
commit c283616
Show file tree

Hide file tree

Showing 2 changed files with 392 additions and 89 deletions.
diff --git a/hydradx/model/amm/omnipool_amm.py b/hydradx/model/amm/omnipool_amm.py
@@ -901,8 +901,14 @@ def execute_add_liquidity(
 ) -> tuple[OmnipoolState, Agent]:
     """Compute new state after liquidity addition"""
 
+    if quantity <= 0:
+        return state.fail_transaction('Quantity must be non-negative.', agent)
+
     delta_Q = lrna_price(state, tkn_add) * quantity
-    if not (state.unique_id, tkn_add) in agent.holdings:
+    if (state.unique_id, tkn_add) in agent.holdings:
+        if agent.holdings[(state.unique_id, tkn_add)] != 0:
+            return state.fail_transaction(f'Agent already has liquidity in pool {tkn_add}.', agent)
+    else:
         agent.holdings[(state.unique_id, tkn_add)] = 0
 
     if agent.holdings[tkn_add] < quantity:

diff --git a/hydradx/notebooks/Omnipool/DynamicFeesComaprison4.ipynb b/hydradx/notebooks/Omnipool/DynamicFeesComaprison4.ipynb